Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index.js can handle a promise returned by handler.js #93

Closed
wants to merge 2 commits into from

Conversation

padiazg
Copy link
Contributor

@padiazg padiazg commented Oct 5, 2018

Proposed in isue #92

Description

The code at index.js calls handler and checks the type of the value returned, if it is a promise then resolves it and then calls the common callback.

How Has This Been Tested?

Build and deploy commenting and uncommenting the code in handler.js, to return either a final value or a promise. Check in Portal.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek derek bot added the new-contributor label Oct 5, 2018
@padiazg padiazg closed this Oct 6, 2018
@padiazg padiazg deleted the handler-as-promise branch October 6, 2018 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant