Use buildx and github actions #76
Conversation
.github/workflows/publish.yaml
Outdated
| with: | ||
| registry: ghcr.io | ||
| username: ${{ github.repository_owner }} | ||
| password: ${{ secrets.CR_PAT }} |
There was a problem hiding this comment.
I need some guidance on what this secret name should be
There was a problem hiding this comment.
Is CR_PAT automated? If not look at our build for faas-netes
There was a problem hiding this comment.
The automatic value is GITHUB_TOKEN but there might be issues with using this to verify the publish flow in forks because it might only have read access, to be frank the docs are not very great about this use case
https://docs.github.com/en/free-pro-team@latest/actions/reference/authentication-in-a-workflow
There was a problem hiding this comment.
Per these docs it worked for github packages https://docs.github.com/en/free-pro-team@latest/actions/guides/publishing-docker-images#publishing-images-to-github-packages and it is the docs that provide for github actions to publish docker images, i was hoping that they didn't deprecate that feature
LucasRoesler
force-pushed
the
migrate-to-buildx-and-gha
branch
2 times, most recently
from
f90f8fe to
c1ec6ab
Compare
|
I have a feeling that secrets.GITHUB_TOKEN doesn't work with GHCR. Can you test and confirm? |
|
Might be better to mirror faas-netes for the build and upload for consistency as that's what we have in place in PRs so far. I'd like to see all of them use the owner name eventually for the image tag so PRs can be tested. |
Can you be more concrete about what you want to see changed. I don't understand what you want me to do. I have already specifically mirrored the changes in faas-netes first and then pulled in the changes from faas-cli that used the owner name. |
|
Have you tested a release build? |
LucasRoesler
force-pushed
the
migrate-to-buildx-and-gha
branch
from
c1ec6ab to
d3d282a
Compare
**What** - Update the Dockerfile to support multiarch builds via buildx - Add Github Action workflow for build and test - Add Github Action workflow to publish the images Signed-off-by: Lucas Roesler <[email protected]>
LucasRoesler
force-pushed
the
migrate-to-buildx-and-gha
branch
from
d3d282a to
ae0053b
Compare
|
@alexellis you can see
|
|
Part of openfaas/faas#1585 |
Description
Motivation and Context
Resolves Migrate from Travis to Github Actions #73
Closes Migrate travis ci to gihub actions #74
How Has This Been Tested?
See https://github.com/LucasRoesler/faas-swarm/actions
Types of changes
Checklist:
git commit -s