Fix npm download to use HTML page instead of API

Fixes: #740

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

npm/.gitignore

@@ -0,0 +1,3 @@
+/.bin
+/node_modules/**
+faas-cli

npm/install.js

@@ -16,9 +16,11 @@ module.exports.install = async () => {
   del.sync(dest, { force: true });
 
   try {
-    let releases = await lib.getReleases();
-    let release = releases.find(release => release.name === name);
-    let url = release && release.browser_download_url;
+
+    let releaseURL = await lib.getRelease()
+    let downloadURL = releaseURL.replace("tag", "download") +"/"+ binaryName;
+
+    let url = downloadURL;
 
     console.log(`Downloading package ${url} to ${dest}`);
     await lib.download(url, dest);
@@ -41,4 +43,4 @@ module.exports.init = () => {
       console.error(err.message);
       process.exit(1);
     });
-}
+}

npm/lib.js

@@ -35,6 +35,19 @@ module.exports = {
         let extname = suffix === '.exe' ? '.exe' : '';
         return `faas-cli${extname}`;
     },
+    getRelease() {
+        return new Promise(async (resolve, reject)=> {
+            let latestURL = "https://github.com/openfaas/faas-cli/releases/latest"
+            let location = ""
+            try {
+                await axios({url:latestURL, maxRedirects:0});
+            }catch (e){
+                location = e.response.headers.location;
+            }
+
+            return resolve(location);
+        })
+    },
     download(url, dest) {
         return new Promise(async (resolve, reject) => {
             let ws = fs.createWriteStream(dest);
@@ -47,10 +60,6 @@ module.exports = {
                 });
         });
     },
-    getReleases() {
-        return axios.get(`https://api.github.com/repos/openfaas/faas-cli/releases/tags/${pkg.version}`)
-            .then(res => res.data.assets);
-    },
     async cmd(...args) {
         let { stdout, stderr } = await exec(...args);
         if (stdout) console.log(stdout);

npm/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openfaas/faas-cli",
-  "version": "0.9.3",
+  "version": "0.11.3-2",
   "description": "OpenFaaS CLI",
   "main": "index.js",
   "bin": {