The initials source code for this demo #1
Conversation
| ] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
🎨 a trailing newline could help match it with the code style of the rest of the app.
| } | |
| } | |
| "@testing-library/jest-dom": "^4.2.4", | ||
| "@testing-library/react": "^9.3.2", | ||
| "@testing-library/user-event": "^7.1.2", | ||
| "@types/jest": "^24.0.0", | ||
| "@types/node": "^12.0.0", | ||
| "@types/react": "^16.9.0", | ||
| "@types/react-dom": "^16.9.0", | ||
| "@types/react-router-dom": "^5.1.5", | ||
| "@types/uuid": "^7.0.3", |
There was a problem hiding this comment.
Testing libraries and types may be well suited to be deb dependencies
| "framer-motion": "2.0.0-beta.70", | ||
| "github-markdown-css": "^4.0.0", | ||
| "jstoxml": "^1.6.6", | ||
| "node-sass": "^4.14.1", |
There was a problem hiding this comment.
node sass as a build tool may be well suited to be a dev dependency
| "react": "^16.13.1", | ||
| "react-dom": "^16.13.1", | ||
| "react-router-dom": "^5.2.0", | ||
| "react-scripts": "3.4.1", |
There was a problem hiding this comment.
react-scripts as a build tool may be well suited to be a dev dependency
| "react-scripts": "3.4.1", | ||
| "remark-html": "^11.0.2", | ||
| "remark-parse": "^8.0.2", | ||
| "typescript": "~3.7.2", |
There was a problem hiding this comment.
typescript as a build tool may be well suited to be a dev dependency
|
|
||
| const ITEM_LOCATION_REGEX = /\/([A-Za-z\-0-9]{1,})\/([0-9]{1,})\/$/; | ||
|
|
||
| const fakeCourses: Course[] = [ |
There was a problem hiding this comment.
Maybe not an immediate priority, this data is currently being bundled with the application.
It might be good to move it to a JSON file served from the public folder.
| <AppBar position="static"> | ||
| <Toolbar> | ||
| <Box display="inline" mr={1}> | ||
| <IconButton edge="start" color="inherit" aria-label="menu" component={RouterLink} to={`/`}> |
There was a problem hiding this comment.
The link appears to be static, does it need to be a template string?
| <IconButton edge="start" color="inherit" aria-label="menu" component={RouterLink} to={`/`}> | |
| <IconButton edge="start" color="inherit" aria-label="menu" component={RouterLink} to="/"> |
| </AppBar> | ||
|
|
||
| <Breadcrumbs aria-label="breadcrumb" className="app-breadcrumbs"> | ||
| <Link color="inherit" component={RouterLink} to={`/`}> |
There was a problem hiding this comment.
| <Link color="inherit" component={RouterLink} to={`/`}> | |
| <Link color="inherit" component={RouterLink} to="/"> |
| @@ -0,0 +1,205 @@ | |||
| // This acts an immutable store. Every change triggers the model to generate an immutable copy | |||
There was a problem hiding this comment.
This seems to have a custom immutability implementation: could something like https://github.com/immerjs/immer or https://lodash.com/docs#cloneDeep help reduce the complexity here?
Or maybe something like https://recoiljs.org ?
| } | ||
|
|
||
| .course-name { | ||
| margin-top: 0px; |
There was a problem hiding this comment.
zero is unitless
| margin-top: 0px; | |
| margin-top: 0; |
No description provided.