Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lenawee County #73

Merged
merged 4 commits into from
Jan 4, 2025

Conversation

migurski
Copy link
Contributor

@migurski migurski commented Jan 3, 2025

Part of #69

Copy link

github-actions bot commented Jan 4, 2025

Thank you for your contribution! Our vote_breakdown_totals test detected some potential issues in the files you added.

======================================================================
FAIL: test_vote_method_totals (data_tests.test_data.VoteBreakdownTotalsTest.test_vote_method_totals) [2024/counties/20241105__mi__general__lenawee__precinct.csv]
----------------------------------------------------------------------
There are 42 rows where the sum of ['early_voting', 'election_day', 'provisional', 'mail'] is not equal to 'votes':

	Headers: ['county', 'precinct', 'office', 'district', 'party', 'candidate', 'votes', 'early_voting', 'election_day', 'provisional', 'mail']:
	Row 2: ['Lenawee', 'City of Adrian, Precinct 1', 'Registered Voters', '', '', '', '2578', '2578', '2578', '', '2578']
	Row 57: ['Lenawee', 'City of Adrian, Precinct 2', 'Registered Voters', '', '', '', '2762', '2762', '2762', '', '2762']
	Row 112: ['Lenawee', 'City of Adrian, Precinct 3', 'Registered Voters', '', '', '', '2987', '2987', '2987', '', '2987']
	Row 167: ['Lenawee', 'City of Adrian, Precinct 4', 'Registered Voters', '', '', '', '2577', '2577', '2577', '', '2577']
	Row 222: ['Lenawee', 'City of Adrian, Precinct 5', 'Registered Voters', '', '', '', '2008', '2008', '2008', '', '2008']
	Row 274: ['Lenawee', 'City of Adrian, Precinct 6', 'Registered Voters', '', '', '', '2615', '2615', '2615', '', '2615']
	Row 329: ['Lenawee', 'City of Hudson, Precinct 1', 'Registered Voters', '', '', '', '1654', '1654', '1654', '', '1654']
	Row 384: ['Lenawee', 'City of Morenci, Precinct 1', 'Registered Voters', '', '', '', '1952', '1952', '1952', '', '1952']
	Row 439: ['Lenawee', 'City of Tecumseh, Precinct 1', 'Registered Voters', '', '', '', '3819', '3819', '3819', '', '3819']
	Row 494: ['Lenawee', 'City of Tecumseh, Precinct 2', 'Registered Voters', '', '', '', '3628', '3628', '3628', '', '3628']
	[Truncated to 10 examples]

Copy link

github-actions bot commented Jan 4, 2025

Thank you for your contribution! Our vote_breakdown_totals test detected some potential issues in the files you added.

======================================================================
FAIL: test_vote_method_totals (data_tests.test_data.VoteBreakdownTotalsTest.test_vote_method_totals) [2024/counties/20241105__mi__general__lenawee__precinct.csv]
----------------------------------------------------------------------
There are 1 rows where the sum of ['early_voting', 'election_day', 'provisional', 'mail'] is not equal to 'votes':

	Headers: ['county', 'precinct', 'office', 'district', 'party', 'candidate', 'votes', 'early_voting', 'election_day', 'provisional', 'mail']:
	Row 799: ['Lenawee', 'Cambridge Township, Precinct 1', 'U.S. House', '5', 'GRN', 'James Bronke', '26', '', '12', '', '10']

@migurski migurski marked this pull request as ready for review January 4, 2025 18:43
@migurski
Copy link
Contributor Author

migurski commented Jan 4, 2025

Remaining failing checks all seem to be for other files in the repo

@dwillis
Copy link
Contributor

dwillis commented Jan 4, 2025

@migurski thank you!

@dwillis dwillis merged commit afdd309 into openelections:master Jan 4, 2025
4 of 8 checks passed
@migurski migurski deleted the migurski/add-lenawee-county branch January 8, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants