Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was using the to_geopandas() functionality to plot our grids in QGIS and saw, that the line geometries were created in a wrong way. This is because lists were used to set up the bus0 and bus1 geometries and from them get the LineString. Lists have a random order wherefore the LineStrings ended up being between random buses. I therefore changed the code to use Series instead, so that the geometry is always matched to a specific line. In the course of that I also enabled that the function can be applied to LV grids and the entire grid topology in the Topology object.
Type of change
Please delete options that are not relevant.
Checklist:
pre-commit
hooksI have made corresponding changes to the documentationIf new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.I have added new features to the corresponding whatsnew file