Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replaced NamedAttributesMetaclass with XBlockMixin #36

Merged
merged 1 commit into from
Apr 23, 2024
Merged

feat: Replaced NamedAttributesMetaclass with XBlockMixin #36

merged 1 commit into from
Apr 23, 2024

Conversation

irfanuddinahmad
Copy link
Contributor

@irfanuddinahmad irfanuddinahmad commented Apr 23, 2024 •
edited
Loading

Description: This PR replaces the NamedAttributesMetaclass with XBlockMixin. The NamedAttributesMetaclass was deprecated in XBlock 3.0

JIRA: ENT-8816 (External Link)

Dependencies: Required to reapply changes in edX custom configurations

Merge deadline: asap

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@irfanuddinahmad irfanuddinahmad merged commit f3c47ca into main Apr 23, 2024
5 checks passed
@irfanuddinahmad irfanuddinahmad deleted the iahmad/ENT-8816 branch April 23, 2024 13:55
@irfanuddinahmad irfanuddinahmad mentioned this pull request Apr 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdmccormick kdmccormick kdmccormick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irfanuddinahmad @kdmccormick