Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-7621: Added the ability to blacklist job-skill relationship. #185

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

saleem-latif
Copy link
Contributor

@saleem-latif saleem-latif commented Oct 19, 2023

Jira Ticket: ENT-7621

Description:
We need a way for admins to view all the skills associated with a job and also the ability to whitelist or blacklist those skills.

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • make upgrade && make requirements have been run to regenerate requirements
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
  • Version bumped
  • Changelog record added

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in course-discovery to upgrade dependencies (including taxonomy-connector)
    • This must be done after the version is visible in PyPi as make upgrade in course-discovery will look for the latest version in PyPi.

@saleem-latif saleem-latif self-assigned this Oct 19, 2023
@saleem-latif saleem-latif force-pushed the saleem-latif/ENT-7621 branch 8 times, most recently from 2ecbe11 to abbc2c6 Compare October 19, 2023 11:34
@saleem-latif saleem-latif force-pushed the saleem-latif/ENT-7621 branch from abbc2c6 to 5486fe3 Compare October 19, 2023 11:41
Copy link
Contributor

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saleem-latif saleem-latif merged commit c35fa23 into master Oct 23, 2023
9 checks passed
@saleem-latif saleem-latif deleted the saleem-latif/ENT-7621 branch October 23, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants