-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC- 0049] feat: Features to enable import/export courses #172
[FC- 0049] feat: Features to enable import/export courses #172
Conversation
- Rename taxonomy._name to taxonomy._export_id - Refactor all code about taxonomy._name - Update resync object tags to update the taxonomy from _export_id - Update tag_object to allow create object_id with invalid tags and taxonomies
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @ChrisChV ! 👍
- I tested this using the Testing Instructions from [FC-0049] Handle tags when importing/exporting courses edx-platform#34356
- I read through the code
-
I checked for accessibility issues - Includes documentation
Thanks @rpenido. I found an issue exporting tags that contains
Could you review that commit? @bradenmacdonald After that, it would be ready for your review. |
Done @ChrisChV! I tested it again and is working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one request about how we handle reserved characters.
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
object_tag._name
toobject_tag._export_id
taxonomy._name
_export_id
tag_object
to allow createobject_id
with invalid tags and taxonomiesexport_id
,
. This character is used as separator on export tags, so causes issues. This separator will change to;
, so we need to avoid to create tags with;
.Support information
Testing instructions
export_id
of the Language taxonomy. On django shell: