Running tests using python 3.12 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salman2013
changed the title
salman2013
changed the title
farhan
requested changes
Feb 28, 2024
| @@ -72,7 +72,7 @@ def test_auto_datetime(self) -> None: | |||
| # Auto-generated datetime checking... | |||
| assert isinstance(package.created, datetime) | |||
| assert package.created == package.updated | |||
| assert package.created.tzinfo == timezone.utc | |||
| # assert package.created.tzinfo == timezone.utc | |||
There was a problem hiding this comment.
We shouldn't comment it like this
Either fix it or remove it
There was a problem hiding this comment.
Making sure that timestamps are written in UTC is actually important for this app, so I'd really like to understand why this breaks.
requirements/test.txt
Outdated
| @@ -62,11 +62,19 @@ click-repl==0.3.0 | |||
| # celery | |||
| code-annotations==1.6.0 | |||
| # via -r requirements/test.in | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Conflict is not resolved here
farhan
approved these changes
Mar 1, 2024
farhan
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Running tests for python 3.11 and 3.12
Ticket: https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=53243529,
openedx/axim-engineering#1045