feat: remove language fixture, Taxonomy.required, make allow_multiple…

… True by default
openedx · Oct 4, 2023 · 946df48 · 946df48
1 parent 5de0969
commit 946df48
Show file tree

Hide file tree

Showing 15 changed files with 124 additions and 1,415 deletions.
diff --git a/...e/tagging/management/commands/__init__.py → openedx_tagging/core/__init__.py b/...e/tagging/management/commands/__init__.py → openedx_tagging/core/__init__.py
diff --git a/openedx_tagging/core/tagging/api.py b/openedx_tagging/core/tagging/api.py
@@ -26,7 +26,6 @@ def create_taxonomy(
     name: str,
     description: str | None = None,
     enabled=True,
-    required=False,
     allow_multiple=False,
     allow_free_text=False,
     taxonomy_class: type[Taxonomy] | None = None,
@@ -38,7 +37,6 @@ def create_taxonomy(
         name=name,
         description=description or "",
         enabled=enabled,
-        required=required,
         allow_multiple=allow_multiple,
         allow_free_text=allow_free_text,
     )
@@ -213,11 +211,6 @@ def _check_new_tag_count(new_tag_count: int) -> None:
     if not taxonomy.allow_multiple and len(tags) > 1:
         raise ValueError(_(f"Taxonomy ({taxonomy.name}) only allows one tag per object."))
 
-    if taxonomy.required and len(tags) == 0:
-        raise ValueError(
-            _(f"Taxonomy ({taxonomy.id}) requires at least one tag per object.")
-        )
-
     current_tags = list(
         ObjectTagClass.objects.filter(taxonomy=taxonomy, object_id=object_id)
     )