Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [FC-0074] use glossary as reference material #221

Merged
merged 11 commits into from
Nov 18, 2024

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Oct 15, 2024

Description

This PR:

  1. Move glossary document to the reference section for better organization.
  2. Use sphinx utilities to implement a glossary.
  3. Reference glossary throughout all documents when needed.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 15, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 15, 2024

Thanks for the pull request, @mariajgrimaldi!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/hooks-extension-framework. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/update-glossary-reference branch from a4d0873 to 7067589 Compare October 15, 2024 12:35
@mariajgrimaldi mariajgrimaldi changed the title docs: use glossary as reference material docs: [FC-0074] use glossary as reference material Oct 31, 2024
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/update-glossary-reference branch from 58c31d9 to 4a92546 Compare November 4, 2024 13:00
@mariajgrimaldi mariajgrimaldi added the FC Relates to an Axim Funded Contribution project label Nov 4, 2024
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/update-glossary-reference branch from 22d1111 to d11e2c9 Compare November 4, 2024 13:10
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review November 4, 2024 13:17
@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner November 4, 2024 13:17
@mariajgrimaldi
Copy link
Member Author

@sarina @Apgomeznext: here's another PR part of the 1.1 Improve Definitions and Update Outdated References in the Framework implementation effort.

@mariajgrimaldi mariajgrimaldi requested a review from sarina November 4, 2024 16:36
docs/reference/glossary.rst Outdated Show resolved Hide resolved
docs/reference/glossary.rst Outdated Show resolved Hide resolved
docs/reference/glossary.rst Outdated Show resolved Hide resolved
The filter type is a unique identifier for the filter, following a standardized format (e.g., reverse DNS style). This type is used as an index for configuring the filter pipeline and specifies which configuration settings apply to a given filter.

Filter Exceptions
Filters can raise exceptions to control the flow of the pipeline. If a filter raises an exception, the pipeline halts, and the exception becomes the pipeline's output. Exceptions are typically raised when certain conditions specified in the filter's logic are met, signaling an event or state change.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are exceptions a recommended practice, or should they be avoided except in extreme cases?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We encourage using exceptions when it makes sense considering the use case of the filter. For example, the course enrollment filter has its own exceptions cause some developers might want to stop the enrollment process when a condition is met. But there are other filters, like changing the IDV URL during runtime, where raising an exception doesn't make much sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good - sounds pretty conditional, don't think another note needs to be made.

@@ -196,7 +198,7 @@ Steps
self.assertDictContainsSubset(attributes, exception.__dict__)

.. note::
Basically, we're testing the filter's signature and the filter's behavior for stopping the process. The first test is testing the filter's signature, which is the set of parameters that the filter receives and returns. The second test is testing the filter's behavior for stopping the process, which is the exception that is raised when the filter stops the process.
Basically, we're testing the :term:`filter signature<Filter Signature>` and the filter's behavior for stopping the process. The first test is testing the :term:`filter signature<Filter Signature>`, which is the set of parameters that the filter receives and returns. The second test is testing the filter's behavior for stopping the process, which is the exception that is raised when the filter stops the process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be explained a little better. But I may not get it right. Maybe,

Suggested change
Basically, we're testing the :term:`filter signature<Filter Signature>` and the filter's behavior for stopping the process. The first test is testing the :term:`filter signature<Filter Signature>`, which is the set of parameters that the filter receives and returns. The second test is testing the filter's behavior for stopping the process, which is the exception that is raised when the filter stops the process.
In this example, we're testing the :term:`filter signature<Filter Signature>` and the filter's behavior for stopping the process. The first test is testing the :term:`filter signature<Filter Signature>`, specifically that the behavior works as expected when passed mock form data. The second test is testing the filter's behavior for stopping the process, which is the exception that is raised when the filter stops the process.

I think the phrase " which is the set of parameters that the filter receives and returns" isn't needed, because we explain that in detail in the lines above the test.

Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this glossary is correct. I was mostly looking at the content and did not review the format at all.

Left a minor comment from what looks like a missing word, nut otherwise good to merge

docs/reference/glossary.rst Outdated Show resolved Hide resolved
@mariajgrimaldi mariajgrimaldi merged commit acbe298 into main Nov 18, 2024
8 checks passed
@mariajgrimaldi mariajgrimaldi deleted the MJG/update-glossary-reference branch November 18, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants