Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validation check on valid url in user agreement model #728

Merged
merged 1 commit into from
Oct 24, 2024
Merged

feat: add validation check on valid url in user agreement model #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions license_manager/apps/subscriptions/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,12 @@ def clean(self):
error_msg = "This field must be blank if 'Has Custom License Expiration Messaging' is unchecked."
errors = {field: error_msg for field in fields_to_check}

# Validate that url_for_button_in_modal is a complete URL
if self.url_for_button_in_modal and not self.url_for_button_in_modal.startswith(("http://", "https://")):
errors["url_for_button_in_modal"] = (
"The URL must start with 'http://' or 'https://'. Please provide a valid URL."
)

# Raise ValidationError if there are any errors
if errors:
raise ValidationError(errors)
Expand Down
Loading