feat: Add field to allow auto-apply without SSO #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brobro10000
force-pushed
the
hu/ent-9426
branch
3 times, most recently
from
b45d32b to
f7ec002
Compare
4 tasks
brobro10000
force-pushed
the
hu/ent-9426
branch
3 times, most recently
from
e98faef to
ffe9a54
Compare
iloveagent57
approved these changes
Oct 7, 2024
adamstankiewicz
approved these changes
Oct 7, 2024
brobro10000
force-pushed
the
hu/ent-9426
branch
from
ffe9a54 to
9b30efd
Compare
brobro10000
force-pushed
the
hu/ent-9426
branch
from
9b30efd to
688d3c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new boolean field to the Customer agreement model labeled
enable_auto_applied_subscriptions_with_universal_link.The default value is false.
Learner portal changes associated with new field: openedx/frontend-app-learner-portal-enterprise#1204
Updates
SubscriptionPlanShouldAutoApplyLicensesChoices, "Unknown" field to dashs ("------").Reason being that Unknown is ambiguous to a user what selecting Unknown actually means or does.
Opted not to explicitly make it a boolean field due to the allow null parameter on the model field.
Testing considerations
already been performed.
Post-review
Squash commits into discrete sets of changes