Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for transfer of all licenses in LicenseTransferJob. #555

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

iloveagent57
Copy link
Contributor

@iloveagent57 iloveagent57 commented Jan 8, 2024

ENT-8197 | Optionally allow license transfer jobs to transfer all licenses from the old plan to the new plan, regardless of license status.

Link to the associated ticket: https://openedx.atlassian.net/browse/ENT-8197

Testing considerations

ENT-8197.mov
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a question/suggestion around the ordering of fields in the Django Admin UI.

license_manager/apps/subscriptions/models.py Show resolved Hide resolved
license_manager/apps/subscriptions/models.py Outdated Show resolved Hide resolved
ENT-8197 | Optionally allow license transfer jobs to transfer all
licenses from the old plan to the new plan, regardless of license status.
@iloveagent57 iloveagent57 merged commit cfca89f into master Jan 9, 2024
5 checks passed
@iloveagent57 iloveagent57 deleted the aed/transfer-all branch January 9, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants