Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify array content type and fix uri #546

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

sameenfatima78
Copy link
Member

Description

Description of changes made

Link to the associated ticket: https://openedx.atlassian.net/browse/ENT-XXXX

Testing considerations

  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

Copy link
Member

@hamzawaleed01 hamzawaleed01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just curious to know that will it work if we keep subscription_plan_uuid as it is? or renaming it to uuid makes any difference?

removed required from usersfids
@sameenfatima78 sameenfatima78 merged commit 8ef2e23 into master Dec 19, 2023
7 checks passed
@sameenfatima78 sameenfatima78 deleted the sameen/fix-api-config branch December 19, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants