Skip to content

Commit

Permalink
feat: upgraded to node v18, added .nvmrc and updated workflows (#89)
Browse files Browse the repository at this point in the history
  • Loading branch information
BilalQamar95 authored May 23, 2023
1 parent 6b2ba05 commit e53cb1c
Show file tree
Hide file tree
Showing 23 changed files with 18,917 additions and 57,354 deletions.
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// eslint-disable-next-line import/no-extraneous-dependencies
const { createConfig } = require('@edx/frontend-build');

module.exports = createConfig('eslint');
9 changes: 4 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,17 @@ on: [push, pull_request]
jobs:
tests:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16]
steps:
- name: Checkout
uses: actions/checkout@v2
with:
fetch-depth: 0
- name: Setup Nodejs Env
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
- name: Setup Nodejs
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
node-version: ${{ env.NODE_VER }}
- name: Install dependencies
run: npm ci
- name: Validate package-lock.json changes
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lockfileversion-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ on:

jobs:
version-check:
uses: openedx/.github/.github/workflows/lockfileversion-check.yml@master
uses: openedx/.github/.github/workflows/lockfileversion-check-v3.yml@master
11 changes: 5 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,15 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v2

# needsfix: this is setting NODE_VER to the string cat .nvmrc
- name: Setup Node.js Env
run: echo "NODE_VER='cat .nvmrc'" >> $GITHUB_ENV

- name: Setup Nodejs Env
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV

- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: 16
node-version: ${{ env.NODE_VER }}

- name: Install dependencies
run: npm ci
- name: Test
Expand Down
3 changes: 1 addition & 2 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
16.14.2

18
Loading

0 comments on commit e53cb1c

Please sign in to comment.