-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display profile name in navbar if available #483
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @navinkarkera! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
1cc6e09
to
a7d1a11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on this, @navinkarkera !
LGTM ✅
- I tested this
- I read through the code
- Includes documentation (N/A)
Probably going to close openedx/frontend-app-learner-dashboard#313 so I'm moving this over here:
FYI @arbrandes / @jmakowski1123 |
src/DesktopHeader.jsx
Outdated
@@ -88,7 +89,7 @@ class DesktopHeader extends React.Component { | |||
className="btn btn-outline-primary d-inline-flex align-items-center pl-2 pr-3" | |||
> | |||
<Avatar size="1.5em" src={avatar} alt="" className="mr-2" /> | |||
{username} <CaretIcon role="img" aria-hidden focusable="false" /> | |||
{name || username} <CaretIcon role="img" aria-hidden focusable="false" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would make so there's no longer a 1:1 relationship between the DesktopHeader props and what is actually shown. In other words, it's not immediately obvious without looking at the implementation what happens if you provide both username and name.
In other words, unless I'm missing something, DesktopHeader has no reason to distinguish between username
and name
. It should just use a single prop, and the business logic of what to actually put there should be up to the user of the component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arbrandes That makes sense. Updated!
Display profile name if it is set, else fallback to username
a7d1a11
to
c3cffff
Compare
@arbrandes Gentle reminder |
Hi @arbrandes @navinkarkera is this still in progress? |
Checking back in on this, @navinkarkera @arbrandes |
Display profile name if it is set, else fallback to username.
Private-ref
: BB-8772Test instructions:
tutor plugins printroot
directory calledmfe_custom_header
.tutor plugins enable mfe_custom_header
.tutor config save
.tutor images build mfe
.tutor dev launch -I
.Now the new header should be installed in all MFEs (except dashboard as it doesn't depend on header component). Login with any user and if the user profile name is not set in
Account
page, you will seeusername
like before. Update profile name by in the account setting page and logout and login again to see the name appear in header right corner.