feat: display profile name in navbar if available #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display profile name if it is set, else fallback to username
CefBoud
reviewed
Apr 10, 2024
CefBoud
approved these changes
Apr 11, 2024
|
@navinkarkera Can you please remember to link the upstream PRs and ticket ID in PRs? It makes it much easier to find the ticket, instead of having to remember which epic it is from and looking through the list of tickets. Same applies to the upstream PRs. E.g. this PR - openedx#483 - doesn't have a link to the ticket, nor any mention of it in the branch or title. |
|
@Cup0fCoffee Yep, I did add all the details to main PR: openedx/edx-platform#34493 but missed to include it in the sub PRs. Updated them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: workflow to publish package to opencraft npm
Private-ref: BB-8772