Skip to content

Commit

Permalink
build: need to install test-app dependencies
Browse files Browse the repository at this point in the history
A prior commit removed a peerDependency on react in the top-level package.json.  This meant that react was no longer installed in the node_modules directory.  When eslint runs, that means it encountered this error:

<local path>/frontend-base/cli/test-app/src/Image.tsx
  1:38  error  Unable to resolve path to module 'react'  import/no-unresolved

The test-app (example back in frontend-build) relied on react being installed, since it’s own dependencies weren’t installed.

This commit actually runs npm ci on the test-app, as we should have been doing.  The fact that it wasn’t breaking in the past was a lucky side effect of how peer dependencies work with npm.
  • Loading branch information
davidjoy committed Jul 3, 2024
1 parent 421dceb commit 8b50622
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ jobs:
with:
node-version: ${{ env.NODE_VER }}
- name: Install dependencies
run: npm ci
run: |
npm ci
cd cli/test-app
npm ci
- name: Lint
run: npm run lint
- name: Test
Expand Down

0 comments on commit 8b50622

Please sign in to comment.