Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove support for Node 18 #365

Merged

Conversation

arslanashraf7
Copy link
Contributor

Description copied over from #352

This PR fixes the conflicts in #352.

Complete the upgrade to Node 20 by removing the Node 18 CI check and going back to using .nvmrc as the source of truth for which version to use.

See #319 for further information.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 4, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @arslanashraf7!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-unmaintained. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c9d0abe) to head (3e8b6ab).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #365   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          111       111           
  Lines         1088      1088           
  Branches       165       165           
=========================================
  Hits          1088      1088           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arslanashraf7
Copy link
Contributor Author

@brian-smith-tcril Thanks for the review. I don't have the merge rights so feel free to merge it whenever you would like.

@brian-smith-tcril
Copy link
Contributor

@arslanashraf7 branch protection rules on this repo require branches be up to date before merge. I just merged another PR that had been waiting so this needs a rebase now. I've already communicated my plan to merge this PR, so as soon as it is rebased I'll hit the button!

@arslanashraf7 arslanashraf7 force-pushed the arslan/remove-node-18-support branch from a1abe0e to 3e8b6ab Compare November 4, 2024 17:33
@arslanashraf7
Copy link
Contributor Author

@arslanashraf7 branch protection rules on this repo require branches be up to date before merge. I just merged another PR that had been waiting so this needs a rebase now. I've already communicated my plan to merge this PR, so as soon as it is rebased I'll hit the button!

@brian-smith-tcril rebased.

@brian-smith-tcril brian-smith-tcril merged commit 7ad1df8 into openedx:master Nov 4, 2024
6 checks passed
@brian-smith-tcril brian-smith-tcril mentioned this pull request Nov 4, 2024
@arslanashraf7 arslanashraf7 deleted the arslan/remove-node-18-support branch November 4, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants