fix: Fix for the Paragon modal shadow, which prevents clicking on an elements on the grading page #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backport from master branch - #357
Minor issue was found on the "View all responses" modal window. This modal window is based on the Paragon Modal component, which has top and bottom shadows to indicate that there is some content at the top or bottom. These shadows are made with
:before
and:after
pseudo-elements and should stick to the top and bottom. Example below:2024-09-25.15.46.53.mov
But in the Grading modal window, the bottom shadow "has a life of its own" and takes various positions on the page, sometimes covering different elements depending on the scroll position or browser window size. Sometimes it's impossible to click the submit button or select a grade.
In the example below, I colored the bottom pseudo-element
:after
in red for clarity, to demonstrate that it’s not sticking to the bottom of the page.2024-09-25.16.00.24.mov
To fix this bug, it is necessary to remove the
height: 100%
property set for.review-modal-body > div.pgn__modal-body-content
. This property was added in this commit: dd880d4After I removed
height: 100%
, I didn’t notice any issues with other elements on the page. Perhaps @leangseu-edx could point out if there’s something I might have missed?2024-09-25.16.03.54.mov