-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mathjax for formules formatting #339
base: master
Are you sure you want to change the base?
feat: Mathjax for formules formatting #339
Conversation
Thanks for the pull request, @vladislavkeblysh! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
cef5cd1
to
7fdea6a
Compare
78d62f7
to
a341093
Compare
Has problem with CI checker. Tried to use node version 18.19 and npm 9/10. Problems still unsolved |
9f68c68
to
3612fe9
Compare
@vladislavkeblysh I tried pulling this locally and running nvm use
npm ci and I was able to reproduce the error CI is showing. I then ran npm install and then npm ci and the error was no longer there. This makes me think that CI should make it past the current error if you run npm install and check in the updated |
@brian-smith-tcril I did the same thing, but the problem persists. |
@vladislavkeblysh what do you see locally when running rm -rf node_modules
nvm use
npm ci |
We'll probably want product review, here. Mathjax support across the platform is somewhat inconsistent, and we'll likely want to figure out a strategy going forward. |
@jmakowski1123 - is there a product roadmap ticket for this? |
Description
Related Pull Requests
Screenshots before:
Screenshots after: