Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Images sizes and src link, blockquote styles (master) #333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Images sizes and src link, blockquote styles (master) #333

wants to merge 1 commit into from
+23 −1

Conversation

vladislavkeblysh
Copy link

@vladislavkeblysh vladislavkeblysh commented Jun 10, 2024 •
edited
Loading

@openedx-webhooks
Copy link

openedx-webhooks commented Jun 10, 2024 •
edited
Loading

Thanks for the pull request, @vladislavkeblysh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @codewithemad. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 10, 2024
@vladislavkeblysh vladislavkeblysh self-assigned this Jun 10, 2024
@vladislavkeblysh vladislavkeblysh changed the title feat: images sizes and blockquote styles (master) feat: Images sizes and src link, blockquote styles (master) Jun 10, 2024
This was referenced Jun 10, 2024
Open
Open
ihor-romaniuk
ihor-romaniuk reviewed Jun 10, 2024
View reviewed changes
src/App.scss Outdated
}

& blockquote > p {
border-left: 2px solid #ccc;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Let's use the paragon color $gray-200 instead of hardcoded color #ccc

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/RGOeX-26243/image-responce-and-quotes branch from aea6b79 to c4a21e7 Compare June 10, 2024 09:03
@mphilbrick211
Copy link

@vladislavkeblysh @ihor-romaniuk - just checking in on this!

@ihor-romaniuk ihor-romaniuk force-pushed the keblysh/feat/RGOeX-26243/image-responce-and-quotes branch from c4a21e7 to 6b301ef Compare August 13, 2024 13:11
@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0219f5c) to head (c31f860).

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #333   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines         1086      1090    +4     
  Branches       166       165    -1     
=========================================
+ Hits          1086      1090    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ihor-romaniuk
Copy link

@mphilbrick211 I believe everything is ready for the final review and merging of this pull request into the quince branch. Could we proceed with that?

@mphilbrick211
Copy link

Hi @ihor-romaniuk. This repo is currently in the process of getting a new maintainer.

@arbrandes @brian-smith-tcril - is one of you able to take a look?

@brian-smith-tcril brian-smith-tcril added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Sep 20, 2024
@brian-smith-tcril
Copy link
Contributor

One thing that feels like it's missing is what input data led to the screenshots in the initial post. @vladislavkeblysh - it would be wonderful if you could update the initial post to include that.

Overall the code changes look good to me, I'd just like to play around with it in a sandbox to try to hit some edge cases before approving/merging. I've added the create-sandbox label to this issue so we can do some live verification.

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@mphilbrick211
Copy link

One thing that feels like it's missing is what input data led to the screenshots in the initial post. @vladislavkeblysh - it would be wonderful if you could update the initial post to include that.

Overall the code changes look good to me, I'd just like to play around with it in a sandbox to try to hit some edge cases before approving/merging. I've added the create-sandbox label to this issue so we can do some live verification.

Hi @vladislavkeblysh! Are you still planning to pursue this pull request?

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@ihor-romaniuk ihor-romaniuk force-pushed the keblysh/feat/RGOeX-26243/image-responce-and-quotes branch from 6b301ef to c31f860 Compare December 11, 2024 13:30
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-romaniuk ihor-romaniuk ihor-romaniuk approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@vladislavkeblysh vladislavkeblysh

Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vladislavkeblysh @openedx-webhooks @mphilbrick211 @ihor-romaniuk @brian-smith-tcril @open-craft-grove