Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "An unexpected error occurred" for ORA response with corrupted attached file for Quince #323

Open
wants to merge 1 commit into
base: open-release/quince.master
Choose a base branch
from

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Mar 21, 2024

This is a backport from the master branch.

Steps to Reproduce:

  1. Answer by the user to ORA -> attach corrupted file.
  2. As staff go to Instructors tab -> Open responses and choose ora -> Click on View all responses

Actual Result:

An unexpected error occurred. Please click the button below to refresh the page:

Знімок екрана 2024-03-21 о 19 45 20

After my edits, it will be displayed in the preview card:

Знімок екрана 2024-03-21 о 19 21 09

Note:

I couldn’t figure out how to change the not-very-correct error message Unknown errors without major modifications.
Here you can select an error message.

@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c644da3) to head (60601e5).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           open-release/quince.master      #323   +/-   ##
============================================================
  Coverage                      100.00%   100.00%           
============================================================
  Files                             110       110           
  Lines                            1079      1080    +1     
  Branches                          159       160    +1     
============================================================
+ Hits                             1079      1080    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroAlipov DmytroAlipov added the bug Report of or fix for something that isn't working as intended label Mar 21, 2024
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Mar 21, 2024
@mphilbrick211 mphilbrick211 requested a review from arbrandes March 21, 2024 20:54
@DmytroAlipov
Copy link
Contributor Author

Hi @mphilbrick211
Is it possible to have someone review this MR so that this fix can be included in Quince 3?

@mphilbrick211
Copy link

Hi @mphilbrick211 Is it possible to have someone review this MR so that this fix can be included in Quince 3?

@arbrandes could you take a look? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. bug Report of or fix for something that isn't working as intended open-source-contribution PR author is not from Axim or 2U
Projects
Status: Backlog
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants