Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove support for the legacy courseware pages #929

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Apr 19, 2022

Access to learners for these pages has been removed, so we don't need to keep any support for it around. Simplifies some code paths.

Access to learners for these pages has been removed, so we don't
need to keep any support for it around. Simplifies some code paths.
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #929 (c2bc8ae) into master (5461c08) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
- Coverage   83.94%   83.93%   -0.02%     
==========================================
  Files         260      260              
  Lines        4491     4475      -16     
  Branches     1161     1152       -9     
==========================================
- Hits         3770     3756      -14     
+ Misses        701      699       -2     
  Partials       20       20              
Impacted Files Coverage Δ
...e/data/__factories__/courseHomeMetadata.factory.js 100.00% <ø> (ø)
src/course-home/data/api.js 83.95% <ø> (ø)
src/courseware/CoursewareRedirectLandingPage.jsx 0.00% <ø> (ø)
src/courseware/data/api.js 100.00% <ø> (ø)
src/tab-page/LoadedTabPage.jsx 100.00% <ø> (ø)
src/course-home/outline-tab/SequenceLink.jsx 73.33% <100.00%> (-4.45%) ⬇️
src/courseware/data/thunks.js 96.51% <100.00%> (-0.08%) ⬇️
src/instructor-toolbar/InstructorToolbar.jsx 100.00% <100.00%> (ø)
src/shared/access.js 100.00% <100.00%> (ø)
src/shared/data/__factories__/block.factory.js 89.47% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5461c08...c2bc8ae. Read the comment docs.

Copy link
Contributor

@cdeery cdeery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does make the front end simpler. Nice.

@mikix mikix merged commit bbff8e7 into master Apr 21, 2022
@mikix mikix deleted the mikix/assume-no-legacy-courseware branch April 21, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants