Skip to content

Commit

Permalink
test: Remove support for Node 18 (#1454)
Browse files Browse the repository at this point in the history
* test: Remove support for Node 18

* chore: update code coverage artifact naming
  • Loading branch information
BilalQamar95 authored and KristinAoki committed Nov 1, 2024
1 parent 8a5a7fc commit 4c9143b
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,16 @@ on:
jobs:
tests:
runs-on: ubuntu-latest
strategy:
matrix:
node: [18, 20]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
node-version-file: '.nvmrc'
- run: make validate.ci
- name: Archive code coverage results
uses: actions/upload-artifact@v4
with:
name: code-coverage-report-${{ matrix.node }}
# When we're only using Node 20, replace the line above with the following:
# name: code-coverage-report
name: code-coverage-report
path: coverage/*.*
coverage:
runs-on: ubuntu-latest
Expand All @@ -33,9 +28,7 @@ jobs:
- name: Download code coverage results
uses: actions/download-artifact@v4
with:
name: code-coverage-report-20
# When we're only using Node 20, replace the line above with the following:
# name: code-coverage-report
name: code-coverage-report
- name: Upload coverage
uses: codecov/codecov-action@v4
with:
Expand Down

0 comments on commit 4c9143b

Please sign in to comment.