-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove duplicative course run card on allocation #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brobro10000
force-pushed
the
hu/ent-9856
branch
from
January 10, 2025 16:32
1b5bf88
to
49e8678
Compare
brobro10000
force-pushed
the
hu/ent-9856
branch
from
January 10, 2025 16:34
49e8678
to
001571c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1248 +/- ##
==========================================
+ Coverage 89.00% 89.21% +0.21%
==========================================
Files 403 405 +2
Lines 8733 8738 +5
Branches 2124 2064 -60
==========================================
+ Hits 7773 7796 +23
+ Misses 918 906 -12
+ Partials 42 36 -6 ☔ View full report in Codecov by Sentry. |
src/components/dashboard/main-content/course-enrollments/data/hooks.js
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/tests/hooks.test.jsx
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/hooks.js
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/tests/hooks.test.jsx
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/tests/hooks.test.jsx
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/tests/hooks.test.jsx
Outdated
Show resolved
Hide resolved
brobro10000
force-pushed
the
hu/ent-9856
branch
from
January 21, 2025 17:51
a6e44cc
to
d7b232c
Compare
brobro10000
force-pushed
the
hu/ent-9856
branch
from
January 21, 2025 18:02
d7b232c
to
0f5a47e
Compare
adamstankiewicz
approved these changes
Jan 22, 2025
src/components/dashboard/main-content/course-enrollments/tests/enrollment-testutils.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the transition to run based assignments, a refactor was missed related to filtering out duplicative learner credit allocations on a potentially upgradable audit enrollment on the learner dashboard page. This did not affect the user's ability to upgrade their audit enrollment. It presented a confusing UI experience on which course card to proceed on (Upgrade or learner credit enrollment.)
This PR removes duplicative course cards by filtering on the course run vs the content key which may either be a top level course or a course run id.
Prior to fix:
After fix:
For all changes
Only if submitting a visual change