Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicative course run card on allocation #1248

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented Jan 9, 2025

During the transition to run based assignments, a refactor was missed related to filtering out duplicative learner credit allocations on a potentially upgradable audit enrollment on the learner dashboard page. This did not affect the user's ability to upgrade their audit enrollment. It presented a confusing UI experience on which course card to proceed on (Upgrade or learner credit enrollment.)

This PR removes duplicative course cards by filtering on the course run vs the content key which may either be a top level course or a course run id.

Prior to fix:
Screenshot 2025-01-10 at 12 05 15 PM

After fix:
Screenshot 2025-01-10 at 12 06 36 PM

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (a8094f0) to head (e63a5fc).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1248      +/-   ##
==========================================
+ Coverage   89.00%   89.21%   +0.21%     
==========================================
  Files         403      405       +2     
  Lines        8733     8738       +5     
  Branches     2124     2064      -60     
==========================================
+ Hits         7773     7796      +23     
+ Misses        918      906      -12     
+ Partials       42       36       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 marked this pull request as ready for review January 10, 2025 17:08
@brobro10000 brobro10000 merged commit 03088e0 into master Jan 23, 2025
6 checks passed
@brobro10000 brobro10000 deleted the hu/ent-9856 branch January 23, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants