Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimistic query update with the BFF inclusion #1231

Merged
merged 17 commits into from
Dec 9, 2024
Merged

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented Dec 4, 2024

Where existing query invalidations and optimistic updates exist for cached query data related to metadata also retrieved from the BFF layer, we add identical logic to invalidate/optimistic update the BFF query cache.

Fixes bug related to passed in args into optimizely within useStatefulEnroll.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@brobro10000 brobro10000 force-pushed the hu/ent-9646-2 branch 2 times, most recently from 037b8c6 to b2128ae Compare December 5, 2024 16:24
@@ -196,7 +195,6 @@ export const InProgressCourseCard = ({
updateCourseEnrollmentStatus({
courseRunId: response.courseRunId,
newStatus: response.courseRunStatus,
savedForLater: response.savedForLater,
Copy link
Member

@adamstankiewicz adamstankiewicz Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch to figure out this line was not really needed (i.e., no savedForLater field in the serialized enrollment).

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (d3920e9) to head (ba0aba2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
+ Coverage   88.85%   88.96%   +0.11%     
==========================================
  Files         401      401              
  Lines        8595     8638      +43     
  Branches     2060     2111      +51     
==========================================
+ Hits         7637     7685      +48     
+ Misses        916      911       -5     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 merged commit 534156c into master Dec 9, 2024
6 checks passed
@brobro10000 brobro10000 deleted the hu/ent-9646-2 branch December 9, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants