-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimistic query update with the BFF inclusion #1231
Conversation
037b8c6
to
b2128ae
Compare
b2128ae
to
70179e1
Compare
@@ -196,7 +195,6 @@ export const InProgressCourseCard = ({ | |||
updateCourseEnrollmentStatus({ | |||
courseRunId: response.courseRunId, | |||
newStatus: response.courseRunStatus, | |||
savedForLater: response.savedForLater, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch to figure out this line was not really needed (i.e., no savedForLater
field in the serialized enrollment).
...components/dashboard/main-content/course-enrollments/course-cards/unenroll/UnenrollModal.jsx
Outdated
Show resolved
Hide resolved
...components/dashboard/main-content/course-enrollments/course-cards/unenroll/UnenrollModal.jsx
Outdated
Show resolved
Hide resolved
...components/dashboard/main-content/course-enrollments/course-cards/unenroll/UnenrollModal.jsx
Outdated
Show resolved
Hide resolved
...components/dashboard/main-content/course-enrollments/course-cards/unenroll/UnenrollModal.jsx
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/hooks.js
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/hooks.js
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
+ Coverage 88.85% 88.96% +0.11%
==========================================
Files 401 401
Lines 8595 8638 +43
Branches 2060 2111 +51
==========================================
+ Hits 7637 7685 +48
+ Misses 916 911 -5
Partials 42 42 ☔ View full report in Codecov by Sentry. |
c11de81
to
d4bb176
Compare
d4bb176
to
1c08837
Compare
9a9df20
to
f717943
Compare
ca37ddd
to
a3a5a28
Compare
src/components/dashboard/main-content/course-enrollments/data/tests/hooks.test.jsx
Outdated
Show resolved
Hide resolved
7fcd81d
to
495f87f
Compare
Where existing query invalidations and optimistic updates exist for cached query data related to metadata also retrieved from the BFF layer, we add identical logic to invalidate/optimistic update the BFF query cache.
Fixes bug related to passed in args into optimizely within
useStatefulEnroll
.For all changes
Only if submitting a visual change