Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed Program link from the header #497

Conversation

PKulkoRaccoonGang
Copy link

@PKulkoRaccoonGang PKulkoRaccoonGang commented Nov 14, 2024

Description

This PR includes several changes primarily focused on removing the programsUrl function and its associated references from various files.

  • removed Program link from the header
  • corrected tests

image

@PKulkoRaccoonGang PKulkoRaccoonGang requested a review from a team as a code owner November 14, 2024 18:00
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 14, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 14, 2024

Thanks for the pull request, @PKulkoRaccoonGang!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @2U-aperture. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft November 14, 2024 18:00
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title fix: removed Program tab in the header fix: removed Program link from the header Nov 14, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Nov 14, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Nov 14, 2024
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/removed-program-tab-in-the-header branch 2 times, most recently from 21c2f87 to 7d8dabe Compare November 14, 2024 21:06
@deborahgu
Copy link
Member

I know this is only a draft, but is this supposed to be doing the same thing as #479, which has been in back-and-forth with reviewers for a bit?

@PKulkoRaccoonGang
Copy link
Author

I know this is only a draft, but is this supposed to be doing the same thing as #479, which has been in back-and-forth with reviewers for a bit?

Yeah, I saw a PR similar to this one. The changes in this PR are for the open-release/redwood.master branch, while this PR #479 is for master and a potential new release 💯

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/removed-program-tab-in-the-header branch from 7d8dabe to 981fff7 Compare November 14, 2024 21:32
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/removed-program-tab-in-the-header branch from 981fff7 to 25d3f83 Compare November 14, 2024 21:35
@PKulkoRaccoonGang PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Nov 14, 2024
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review November 15, 2024 07:52
@cmltaWt0 cmltaWt0 merged commit 82dbc27 into openedx:open-release/redwood.master Nov 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants