test: Remove support for Node 18 #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
=======================================
Coverage 93.18% 93.18%
=======================================
Files 161 161
Lines 3404 3404
Branches 914 919 +5
=======================================
Hits 3172 3172
Misses 215 215
Partials 17 17 ☔ View full report in Codecov by Sentry. |
sundasnoreen12
approved these changes
Sep 10, 2024
awais-ansari
approved these changes
Sep 10, 2024
brian-smith-tcril
added a commit
to brian-smith-tcril/frontend-app-discussions
that referenced
this pull request
Sep 30, 2024
This reverts commit dc5f097. Node 18 removal PRs should be merged after Sumac is cut.
brian-smith-tcril
added a commit
that referenced
this pull request
Oct 22, 2024
brian-smith-tcril
added a commit
to brian-smith-tcril/frontend-app-discussions
that referenced
this pull request
Oct 31, 2024
This reverts commit 472bbe2.
brian-smith-tcril
added a commit
to brian-smith-tcril/frontend-app-discussions
that referenced
this pull request
Oct 31, 2024
brian-smith-tcril
added a commit
to brian-smith-tcril/frontend-app-discussions
that referenced
this pull request
Oct 31, 2024
brian-smith-tcril
added a commit
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completed upgrade to Node 20 by removing the Node 18 CI check and using
.nvmrcfor version to use.See the tracking issue for further information.