-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Upgrade to Node 20 #734
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
=======================================
Coverage 93.18% 93.18%
=======================================
Files 161 161
Lines 3404 3404
Branches 924 919 -5
=======================================
Hits 3172 3172
- Misses 214 215 +1
+ Partials 18 17 -1 ☔ View full report in Codecov by Sentry. |
PR will be updated and ready for review once the prerequisite PR for first step of the node v20 upgrade process is reviewed/merged. |
…ussions into bilalqamar95/node-v20-upgrade
This one doesn't seem to have any lockfile changes. I see all the CI checks are passing so I assume that's fine, I just would like to make sure that is expected here. |
Thanks for bring this to my attention. I double checked, regenerating package lock following the recommended process process ( |
Description
package-lock.json
with nodev20
and NPM10
..nvmrc
tov20
lockfile
version check workflowSecond step in the Node 20 upgrade process, See the tracking issue for futher information.