Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Node 20 #734

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Aug 12, 2024

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

Second step in the Node 20 upgrade process, See the tracking issue for futher information.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (0d6692c) to head (e3a7fbd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files         161      161           
  Lines        3404     3404           
  Branches      924      919    -5     
=======================================
  Hits         3172     3172           
- Misses        214      215    +1     
+ Partials       18       17    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 self-assigned this Aug 21, 2024
@BilalQamar95 BilalQamar95 marked this pull request as draft August 21, 2024 08:41
@BilalQamar95
Copy link
Contributor Author

PR will be updated and ready for review once the prerequisite PR for first step of the node v20 upgrade process is reviewed/merged.

@BilalQamar95 BilalQamar95 changed the title feat: updated node to v20 build: Upgrade to Node 20 Aug 21, 2024
@BilalQamar95 BilalQamar95 marked this pull request as ready for review August 23, 2024 11:30
@BilalQamar95 BilalQamar95 mentioned this pull request Aug 23, 2024
@brian-smith-tcril
Copy link
Contributor

This one doesn't seem to have any lockfile changes. I see all the CI checks are passing so I assume that's fine, I just would like to make sure that is expected here.

@BilalQamar95
Copy link
Contributor Author

This one doesn't seem to have any lockfile changes. I see all the CI checks are passing so I assume that's fine, I just would like to make sure that is expected here.

Thanks for bring this to my attention. I double checked, regenerating package lock following the recommended process process (nvm use && rm package-lock.json && npm install) brings no change to lock file. However I did a clean install with both package-lock and node-modules removed & package-lock got updated.

@brian-smith-tcril brian-smith-tcril merged commit 5e8c825 into master Sep 3, 2024
7 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/node-v20-upgrade branch September 3, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants