-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create collection Modal [FC-0062] #1259
Merged
ChrisChV
merged 17 commits into
openedx:master
from
open-craft:chris/FAL-3788-create-collection
Sep 14, 2024
Merged
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e3c3076
feat: Enable Collection button on Create Component in Library
ChrisChV 718ff7f
feat: CreateCollectionModal added
ChrisChV ea2ba75
feat: Connect CreateCollectionModal with API
ChrisChV ac50a2f
test: For CreateCollectionModal
ChrisChV 36f2e8b
style: Nits on library authoring code
ChrisChV aa870b4
refactor: Use Formik + Yup in CreateCollectionModal
ChrisChV 3dfe252
style: Fix lint on the code
ChrisChV b0a47cc
style: Delete rounded-0 in AddContentButton
ChrisChV af89cf3
chore: fix merge conflicts
ChrisChV 636d231
refactor: Some parts of Formik in CreateCollectionModal
ChrisChV 73fe5ff
style: Update code from review
ChrisChV 8a57c26
chore: fix merge conflicts
ChrisChV 104fce1
style: Trow error on CreateCollectionModal if libraryId is null
ChrisChV d17367c
chore: Fix merge conflicts
ChrisChV fac82ea
fix: Open CreateCollectionModal on EmptyStates add collection button
ChrisChV e26b90e
refactor: Migrate FormikControl to TypeScript
ChrisChV 8dfe82c
test: Add tests for EmptyStates
ChrisChV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label
is still always aPropTypes.element
.. andhelp
would be if you just wrapped it in a<Form.Text>
element.So rather than making this change, can we please just call it with elements instead of strings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure