-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up dependencies [FC-0062] #1255
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,7 @@ | |
"@dnd-kit/sortable": "^8.0.0", | ||
"@dnd-kit/utilities": "^3.2.2", | ||
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.3", | ||
"@edx/browserslist-config": "1.2.0", | ||
"@edx/frontend-component-footer": "^14.0.3", | ||
"@edx/frontend-component-header": "^5.3.3", | ||
"@edx/frontend-enterprise-hotjar": "^2.0.0", | ||
|
@@ -62,6 +63,7 @@ | |
"@openedx-plugins/course-app-teams": "file:plugins/course-apps/teams", | ||
"@openedx-plugins/course-app-wiki": "file:plugins/course-apps/wiki", | ||
"@openedx-plugins/course-app-xpert_unit_summary": "file:plugins/course-apps/xpert_unit_summary", | ||
"@openedx/frontend-build": "^14.0.14", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
"@openedx/frontend-plugin-framework": "^1.2.1", | ||
"@openedx/paragon": "^22.5.1", | ||
"@redux-devtools/extension": "^3.3.0", | ||
|
@@ -97,7 +99,6 @@ | |
"react-transition-group": "4.4.5", | ||
"redux": "4.0.5", | ||
"redux-logger": "^3.0.6", | ||
"redux-mock-store": "^1.5.4", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is only used in tests, so it's supposed to be a |
||
"redux-thunk": "^2.4.1", | ||
"reselect": "^4.1.5", | ||
"start": "^5.1.0", | ||
|
@@ -108,30 +109,21 @@ | |
"yup": "0.31.1" | ||
}, | ||
"devDependencies": { | ||
"@edx/browserslist-config": "1.2.0", | ||
"@edx/react-unit-test-utils": "3.0.0", | ||
"@edx/reactifex": "^1.0.3", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't appear to be used [directly] in this MFE. |
||
"@edx/stylelint-config-edx": "2.3.3", | ||
"@edx/typescript-config": "^1.0.1", | ||
"@openedx/frontend-build": "^14.0.14", | ||
"@testing-library/jest-dom": "5.17.0", | ||
"@testing-library/react": "12.1.5", | ||
"@testing-library/react-hooks": "^8.0.1", | ||
"@testing-library/user-event": "^13.2.1", | ||
"@types/lodash": "^4.17.7", | ||
"axios": "^0.28.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We shouldn't specify an |
||
"axios-mock-adapter": "1.22.0", | ||
"eslint-import-resolver-webpack": "^0.13.8", | ||
"fetch-mock-jest": "^1.5.1", | ||
"glob": "7.2.3", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't appear to be used [directly] in this MFE. |
||
"husky": "7.0.4", | ||
"jest-canvas-mock": "^2.5.2", | ||
"jest-expect-message": "^1.1.3", | ||
"react-test-renderer": "17.0.2", | ||
"reactifex": "1.1.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't appear to be used [directly] in this MFE. |
||
"ts-loader": "^9.5.1" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TS support is configured by |
||
}, | ||
"peerDependencies": { | ||
"decode-uri-component": ">=0.2.2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't appear to be used [directly] in this MFE. |
||
"redux-mock-store": "^1.5.4" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
browserslist-config
is required for webpack to build the MFE so it should be a dependency, not a devDependency.Ref: OEP-67 - Frontend Technology Selection - 15 Development dependencies should be separated into devDependencies