Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Components: Component sidebar #1045

Closed
ChrisChV opened this issue May 24, 2024 · 10 comments
Closed

Library Components: Component sidebar #1045

ChrisChV opened this issue May 24, 2024 · 10 comments

Comments

@ChrisChV
Copy link
Contributor

ChrisChV commented May 24, 2024

✅ In Scope:

  1. Clicking on any component tile once will open the component sidebar.
  2. If the Library sidebar or the Collection sidebar is already opened, it will close and be replaced by the Component sidebar, once the component tile is clicked.
  3. The Component sidebar contains three tabs: Preview, Manage and Details. Preview always opens by default when the Sidebar is first opened. [note the designs have "organize" instead of "manage", but we use "manage" on the collections sidebar and I'd prefer to keep it consistent]
  4. Users can close the Sidebar by clicking the "x" in the upper right corner. When the sidebar is closed, the number of content tiles is responsive and occupies the space instead.
  5. The Component Info header allows users to change the collection name (but only show the pencil icon if the user has permission to edit the library)
  6. The header contains two buttons - Edit and Publish. Clicking Edit opens the requisite editor window for the component (won't be functional until Epic 4, so can just add the empty button for now). Clicking Publish opens the confirmation modal (won't be functional until later, so can just add the empty button for now).
  7. The 3-dot menu should contain the same actions as the three-dot menu on the component cards: UX story - Design dropdown for 3-dot menu on component cards #1105
Screen Shot 2024-07-29 at 3 49 33 PM

Each tab in the component sidebar contains specific functionality and will be defined in separate stories under Epic 3.

@bradenmacdonald
Copy link
Contributor

@ChrisChV This will be part of another epic (3, not 1). Epic 3 will be building various sidebars. The only sidebar we'll build in epic 1 is the "Library Info Sidebar" to rename the library.

@ChrisChV
Copy link
Contributor Author

This will be part of another epic (3, not 1). Epic 3 will be building various sidebars. The only sidebar we'll build in epic 1 is the "Library Info Sidebar" to rename the library.

@bradenmacdonald Ok. So #1042 is not part of the epic 1?

@bradenmacdonald
Copy link
Contributor

@ChrisChV At the moment it's not part of the epic, but we may add it back in.

@rpenido
Copy link
Contributor

rpenido commented Aug 30, 2024

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox!

@lizc577
Copy link

lizc577 commented Aug 30, 2024

Image

Couple of notes (see screenshot)-

  1. When I made the title long, the hover state on the edit icon is getting skewed
  2. At this breakpoint, the 3 dot menu is falling below the edit/publish buttons, can we make it so that the 3 dot menu is never on its own line?

Not in screenshot -
It looks like we are showing "More... " in the tab menu when there is still room to fit "Details". I'm also not sure about the need for "More" when there is just one tab in the menu, I think we should always keep it as Details when it is the only tab being cut off, and if needed truncate the word Details. Move to "More.." menu when the breakpoint requires more than 1 tab to be in the "More" menu item drop down. (cc @sdaitzman, lmk if you have any thoughts here)

@bradenmacdonald
Copy link
Contributor

It looks like we are showing "More... " in the tab menu when there is still room to fit "Details". I'm also not sure about the need for "More" when there is just one tab in the menu, I think we should always keep it as Details when it is the only tab being cut off, and if needed truncate the word Details. Move to "More.." menu when the breakpoint requires more than 1 tab to be in the "More" menu item drop down. (cc @sdaitzman, lmk if you have any thoughts here)

We opened a separate issue for that: openedx/paragon#3200

@rpenido
Copy link
Contributor

rpenido commented Sep 18, 2024

Hi @lizc577! Sorry for missing your comments!

  1. When I made the title long, the hover state on the edit icon is getting skewed

I'm fixing it as part of #1293

  1. At this breakpoint, the 3 dot menu is falling below the edit/publish buttons, can we make it so that the 3 dot menu is never on its own line?

I didn't find a way to fix this in the current component, but we added a fixed width that prevents this from happening (at least on English)

@jmakowski1123
Copy link

jmakowski1123 commented Sep 20, 2024

  1. There some weird spillover of the tag counts when the sidebar is opened and the tile text seems to hit a threshold length (not sure what that is).
Screen Shot 2024-09-20 at 12 54 48 PM
  1. I'm getting an error message when I click on the pencil icon to edit a component title from the sidebar. I can edit the text field, but the update doesn't save.
Screen Shot 2024-09-20 at 12 56 53 PM

@rpenido
Copy link
Contributor

rpenido commented Oct 3, 2024

@jmakowski1123 @lizc577 @sdaitzman @marcotuts The issues mentioned here should be fixed in the sandbox

@jmakowski1123
Copy link

It looks like another UI bug was introduced with the 3-dot fix - now the expand button overlays on top of the 3-dot menu when it's expanded. I've created a separate bug ticket #1390

Screen Shot 2024-10-16 at 2 51 26 PM

@jmakowski1123 jmakowski1123 moved this from Ready for AC testing to Done in Libraries Overhaul Oct 24, 2024
@jmakowski1123 jmakowski1123 closed this as completed by moving to Done in Libraries Overhaul Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants