Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Sidebar: Manage tab #1190

Closed
jmakowski1123 opened this issue Jul 29, 2024 · 4 comments
Closed

Component Sidebar: Manage tab #1190

jmakowski1123 opened this issue Jul 29, 2024 · 4 comments

Comments

@jmakowski1123
Copy link

To be completed after: #1045

  1. The Manage tab contains two collapsible spaces - Publish Status and Tags. Both should be opened by default when the Manage tab is clicked.
  2. The Publish status contains the following data: Publishing Status (Published, Draft, Unpublished changes); time stamp when the draft was last auto-saved.
  3. Out of scope - release date and visibility settings.
  4. The Tags space cannot be developed until Epic 5; for now, the space should just exist.

Image

@rpenido
Copy link
Contributor

rpenido commented Sep 17, 2024

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@sdaitzman
Copy link

Thanks, @rpenido. I noticed that when switching between sidebar tabs, or switching between the component and library sidebars, the sidebar size changes which makes the whole page reflow. If possible, it would be great to keep sidebar size consistent when switching sidebars/sidebar tabs.

Screen Recording 2024-09-17 at 9 19 51 AM

@rpenido
Copy link
Contributor

rpenido commented Sep 17, 2024

Hi @sdaitzman !
I updated the sandbox, setting the width of the sidebar to be fixed and prevent this issue.
Also, I created a PR to fix it upstream here:

This includes the changes requested here (#1221). It is only missing the header/footer size change.

@jmakowski1123
Copy link
Author

This looks good!

@ChrisChV ChrisChV moved this from Ready for AC testing to Done in Libraries Overhaul Oct 4, 2024
@ChrisChV ChrisChV closed this as completed by moving to Done in Libraries Overhaul Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants