Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the display of username suggestions #1278

Open
wants to merge 1 commit into
base: open-release/quince.master
Choose a base branch
from

Conversation

khudym
Copy link

@khudym khudym commented Jul 5, 2024

Description

Username suggestions functionality has been corrected to ensure proper behaviour.

  • fixed issue with suggestions being displayed in the wrong place;
  • added the ability to navigate through suggestions using the keyboard.

Related Pull Requests
PR to the open-release/redwood.master branch: #1279
PR to the master branch: #1270

Steps to Reproduce:

1. suggestions being displayed in the wrong place

Open register page -> Enter some string into field "Full name" (e.g. Jack Smith) -> Click on field "Public username"

suggestions_rendering_bug.mov

2. impossible to enter suggestions field using the keyboard

Open register page -> Enter some string into field "Full name" (e.g. Jack Smith) -> press Tab button until you get to the "Public username" field

suggestions_keyboard.mov

After changes:

1. suggestions being displayed in the wrong place

fixed_suggestions_rendering_bug.mov

2. impossible to enter suggestions field using the keyboard

fixed_suggestions_keyboard.mov

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

openedx-webhooks commented Jul 5, 2024

Thanks for the pull request, @khudym! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 5, 2024
@khudym khudym changed the title fix: username suggestions alignment fix: the display of username suggestions Jul 5, 2024
@khudym khudym marked this pull request as ready for review July 5, 2024 07:52
@mphilbrick211 mphilbrick211 requested a review from a team July 16, 2024 20:16
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Jul 16, 2024
@mphilbrick211 mphilbrick211 requested review from a team and removed request for a team December 9, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Backlog
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants