[Quince backport] chore: bump frontend-platform (#1076) #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When country is not required to submit, the displayValue check will always return true. This fixes it by only check it if it's needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS` This issue might has been discoverd at edx.org becuase edx.org requires the Country to be filled when creating an account, however this is not the case for Open edX by default, hence the issue reported below Ref: openedx/wg-build-test-release/issues/318
arbrandes
changed the title
arbrandes
merged commit db4eeac
into
openedx:open-release/quince.master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1099 to
quince.master.