-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unification of the appearance of buttons #1092
feat: unification of the appearance of buttons #1092
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1092 +/- ##
=======================================
Coverage 87.08% 87.08%
=======================================
Files 124 124
Lines 2276 2276
Branches 634 634
=======================================
Hits 1982 1982
Misses 285 285
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Hi @openedx/vanguards! This is ready for review / merge. Thanks! |
@ihor-romaniuk I will have to check the documentation for the SSO providers like Apple, Google, Microsoft. As far I know, we cannot change the background color. (We have had issues in the past when we changed branding for these buttons) |
@zainab-amir Hello. |
@ihor-romaniuk we have created a ticket to investigate. We will update you within 2 weeks (current sprint). |
@ihor-romaniuk Modifications to the single sign-on buttons of companies such as Facebook and Google are not possible due to their strict brand guidelines. See these for reference: However, I recognize the value in adapting custom SSO buttons to match the website's overall theme. So I propose you change your code to apply the changes to only custom SSO buttons and not the ones that have icon class coming from the backend.
|
@ihor-romaniuk will you be making the changes? |
Hi @ihor-romaniuk - just following up on this. |
Closing this for now. Can reopen if the future if needed. Thanks! |
@ihor-romaniuk Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This pull request contains recommendations to improve the display of button blocks for oauth2 providers.
The main goal is to make the buttons appear uniform so that it looks more aesthetically pleasing and consistent.
Also, removing SCSS-specific variables and using the variables provided by the Paragon library.
Related Pull Requests
PR to the open-release/palm.master branch: #1090
PR to the open-release/quince.master branch: #1091
Screenshots
Merge Checklist
Post-merge Checklist