Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unification of the appearance of buttons #1092

Conversation

ihor-romaniuk
Copy link
Contributor

Description

This pull request contains recommendations to improve the display of button blocks for oauth2 providers.
The main goal is to make the buttons appear uniform so that it looks more aesthetically pleasing and consistent.
Also, removing SCSS-specific variables and using the variables provided by the Paragon library.

Related Pull Requests

PR to the open-release/palm.master branch: #1090
PR to the open-release/quince.master branch: #1091

Screenshots

Before After
image image

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@ihor-romaniuk ihor-romaniuk requested a review from a team as a code owner October 27, 2023 12:23
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 27, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 27, 2023

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c097b5b) 87.08% compared to head (f214c33) 87.08%.
Report is 34 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1092   +/-   ##
=======================================
  Coverage   87.08%   87.08%           
=======================================
  Files         124      124           
  Lines        2276     2276           
  Branches      634      634           
=======================================
  Hits         1982     1982           
  Misses        285      285           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 27, 2023
@mphilbrick211
Copy link

Hi @openedx/vanguards! This is ready for review / merge. Thanks!

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 30, 2023
@zainab-amir
Copy link
Contributor

zainab-amir commented Nov 17, 2023

@ihor-romaniuk I will have to check the documentation for the SSO providers like Apple, Google, Microsoft. As far I know, we cannot change the background color. (We have had issues in the past when we changed branding for these buttons)

@ihor-romaniuk
Copy link
Contributor Author

@zainab-amir Hello.
Do we have any updates about possibilities to change SSO provider button colors? Or will we close this pull request due to inability to apply it?

@zainab-amir
Copy link
Contributor

@ihor-romaniuk we have created a ticket to investigate. We will update you within 2 weeks (current sprint).

@zainab-amir
Copy link
Contributor

zainab-amir commented Nov 29, 2023

@ihor-romaniuk Modifications to the single sign-on buttons of companies such as Facebook and Google are not possible due to their strict brand guidelines. See these for reference:

However, I recognize the value in adapting custom SSO buttons to match the website's overall theme. So I propose you change your code to apply the changes to only custom SSO buttons and not the ones that have icon class coming from the backend.

Before After
Screenshot 2023-11-28 at 11 10 02 PM Screenshot 2023-11-28 at 11 09 41 PM

@zainab-amir zainab-amir added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Dec 4, 2023
@zainab-amir
Copy link
Contributor

zainab-amir commented Dec 7, 2023

@ihor-romaniuk will you be making the changes?

@mphilbrick211
Copy link

@ihor-romaniuk will you be making the changed?

Hi @ihor-romaniuk - just following up on this.

@cmltaWt0 cmltaWt0 added the product review PR requires product review before merging label Feb 8, 2024
@mphilbrick211
Copy link

Closing this for now. Can reopen if the future if needed. Thanks!

@openedx-webhooks
Copy link

@ihor-romaniuk Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@mphilbrick211 mphilbrick211 added the closed inactivity PR was closed because the author abandoned it label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed inactivity PR was closed because the author abandoned it open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants