-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enabling the ability to log in with a username consisting of 2 characters #1072
fix: Enabling the ability to log in with a username consisting of 2 characters #1072
Conversation
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
6bf7cff
to
4ac053b
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/palm.master #1072 +/- ##
===========================================================
Coverage ? 83.42%
===========================================================
Files ? 101
Lines ? 2099
Branches ? 585
===========================================================
Hits ? 1751
Misses ? 335
Partials ? 13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
1eaebeb
into
openedx:open-release/palm.master
@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
For now, we have the ability to register with a username consisting of 2 characters. However, when we try to log in with this username, we receive an error indicating that the 'username should be at least 3 characters.' In this PR, we fix this bug.
Before
2023-10-11.17.32.42.mov
2023-10-11.17.40.09.mov
After
2023-10-11.17.41.42.mov