Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enabling the ability to log in with a username consisting of 2 characters #1072

Conversation

Lunyachek
Copy link
Contributor

@Lunyachek Lunyachek commented Oct 11, 2023

Description

For now, we have the ability to register with a username consisting of 2 characters. However, when we try to log in with this username, we receive an error indicating that the 'username should be at least 3 characters.' In this PR, we fix this bug.

Before

2023-10-11.17.32.42.mov
2023-10-11.17.40.09.mov

After

2023-10-11.17.41.42.mov

@Lunyachek Lunyachek requested a review from a team as a code owner October 11, 2023 14:44
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 11, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Lunyachek Lunyachek force-pushed the lunyachek/fix/login-two-characters-username-palm branch from 6bf7cff to 4ac053b Compare October 11, 2023 14:45
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/palm.master@17e18e9). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             open-release/palm.master    #1072   +/-   ##
===========================================================
  Coverage                            ?   83.42%           
===========================================================
  Files                               ?      101           
  Lines                               ?     2099           
  Branches                            ?      585           
===========================================================
  Hits                                ?     1751           
  Misses                              ?      335           
  Partials                            ?       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 11, 2023
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Oct 31, 2023
Copy link
Contributor

@attiyaIshaque attiyaIshaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@attiyaIshaque attiyaIshaque merged commit 1eaebeb into openedx:open-release/palm.master Nov 22, 2023
5 checks passed
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 23, 2023
@Lunyachek Lunyachek deleted the lunyachek/fix/login-two-characters-username-palm branch January 16, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants