Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open popular recs collapsible by default when there are no personalized recs #1053

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

syedsajjadkazmii
Copy link
Contributor

Description

Added fix for

  • Open popular recs collapsible by default for small screens when there are no personalized recs
  • Handle eventing accoring to it ^

JIRA

VAN-1642

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if its not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@syedsajjadkazmii syedsajjadkazmii requested a review from a team as a code owner September 4, 2023 10:32
@syedsajjadkazmii syedsajjadkazmii changed the base branch from master to recommendations-v2 September 4, 2023 10:32
@syedsajjadkazmii syedsajjadkazmii changed the title Sajjad/van 1642 Open popular recs collapsible by default when there are no personalized recs Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.28% 🎉

Comparison is base (8c65c35) 86.03% compared to head (9d094d5) 86.32%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           recommendations-v2    #1053      +/-   ##
======================================================
+ Coverage               86.03%   86.32%   +0.28%     
======================================================
  Files                     121      121              
  Lines                    2285     2289       +4     
  Branches                  654      656       +2     
======================================================
+ Hits                     1966     1976      +10     
+ Misses                    308      302       -6     
  Partials                   11       11              
Files Changed Coverage Δ
src/recommendations/data/tests/mockedData.js 100.00% <ø> (ø)
...dations/RecommendationsPageLayouts/SmallLayout.jsx 100.00% <100.00%> (+26.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1642 branch 2 times, most recently from a47430f to bc4a9d6 Compare September 4, 2023 12:15
@syedsajjadkazmii syedsajjadkazmii merged commit b8a6170 into recommendations-v2 Sep 4, 2023
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/VAN-1642 branch September 4, 2023 12:42
zainab-amir pushed a commit that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants