Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to _read_pending_msgs #130

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Oct 3, 2024

These redis methods don't timeout and can cause infinite hangs when redis goes down while reading the pending messages. We wrap them in our own timeouts now and make those trigger consumer restarts to force reconnects and prevent the hangs.

These redis methods don't timeout and can cause infinite hangs when
redis goes down while reading the pending messages. We wrap them in our
own timeouts now and make those trigger consumer restarts to force
reconnects and prevent the hangs.
@bmtcril bmtcril force-pushed the bmtcril/add_pending_msg_timeouts branch from 558f9de to 326fbc1 Compare October 3, 2024 18:29
@bmtcril bmtcril requested a review from saraburns1 October 3, 2024 18:30
@navinkarkera navinkarkera merged commit e2542d4 into main Oct 12, 2024
12 checks passed
@navinkarkera navinkarkera deleted the bmtcril/add_pending_msg_timeouts branch October 12, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants