fix: Add monitoring information inside the function trace. #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianakhuang
force-pushed
the
diana/add-monitoring-information
branch
2 times, most recently
from
7500819 to
183b4d2
Compare
timmc-edx
reviewed
Aug 1, 2024
Moved function_trace call to a higher level to capture more information about the overall inner loop of the consumer. Also renamed the function trace to ``consumer.consume`` so it's clearer from the outside.
dianakhuang
force-pushed
the
diana/add-monitoring-information
branch
from
183b4d2 to
16646df
Compare
timmc-edx
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved function_trace call to a higher level to capture more information about the overall inner loop of the consumer. Also renamed the function trace to
consumer.consumeso it's clearer from the outside what the span is doing.Merge checklist:
Check off if complete or not applicable: