feat: update get_content_metadata_for_customer to use v2 endpoint #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ class EnterpriseCatalogApiClient(BaseOAuthClient): | |||
| """ | |||
| API client for calls to the enterprise service. | |||
| """ | |||
| api_base_url = urljoin(settings.ENTERPRISE_CATALOG_URL, 'api/v1/') | |||
| api_base_url = urljoin(settings.ENTERPRISE_CATALOG_URL, 'api/v2/') | |||
There was a problem hiding this comment.
Do we need every v1 endpoint in enterprise-catalog to have a functional v2 version (even if using the same exact logic as v1)?
There was a problem hiding this comment.
Nope, I was thinking of elaborating on this by adding a constructor argument to ask for the API version.
pwnage101
force-pushed
the
pwnage101/ENT-9410
branch
3 times, most recently
from
baa375a
to
7f239c1
Compare
pwnage101
force-pushed
the
pwnage101/ENT-9410
branch
from
7f239c1
to
736851b
Compare
pwnage101
changed the title
iloveagent57
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENT-9410