Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: skip customer fetch in content_metadata view #166

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat: skip customer fetch in content_metadata view #166

merged 1 commit into from
Oct 30, 2023

Conversation

iloveagent57
Copy link
Contributor

Description

Include the skip_customer_fetch param on calls to fetch customer content metadata. See openedx/enterprise-catalog#702

Merge checklist

  • All reviewers approved
  • CI build is green
  • Documentation updated (not only docstrings)
  • Commits are squashed

@iloveagent57 iloveagent57 force-pushed the aed/skip-customer-fetch branch from feed48e to 715e8b9 Compare October 30, 2023 15:00
adamstankiewicz
adamstankiewicz approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One clarifying question around whether skip_customer_fetch is intended to be enabled or disabled by default and a minor docs nit. Looks good, though!

enterprise_subsidy/apps/api_client/enterprise_catalog.py Outdated Show resolved Hide resolved
enterprise_subsidy/apps/api_client/enterprise_catalog.py Outdated Show resolved Hide resolved
@iloveagent57 iloveagent57 force-pushed the aed/skip-customer-fetch branch from 715e8b9 to a237145 Compare October 30, 2023 15:35
@iloveagent57 iloveagent57 merged commit 190a779 into main Oct 30, 2023
7 checks passed
@iloveagent57 iloveagent57 deleted the aed/skip-customer-fetch branch October 30, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iloveagent57 @adamstankiewicz