Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Assume that SoftwareSecure PII is retained (to fix annotations) #1247

Merged
merged 1 commit into from
Nov 21, 2024
Merged

build: Assume that SoftwareSecure PII is retained (to fix annotations) #1247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ Change Log
Unreleased
~~~~~~~~~~


[4.18.4] - 2024-11-21
~~~~~~~~~~~~~~~~~~~~~
* fix PII annotations by assuming that if a model's retirement is 'to_be_implemented', then we should just say it is 'retained'.

[4.18.3] - 2024-11-04
~~~~~~~~~~~~~~~~~~~~~
* add management command to delete attempts
Expand Down
2 changes: 1 addition & 1 deletion edx_proctoring/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
"""

# Be sure to update the version number in edx_proctoring/package.json
__version__ = '4.18.3'
__version__ = '4.18.4'
24 changes: 15 additions & 9 deletions edx_proctoring/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,10 +685,12 @@ class ProctoredExamSoftwareSecureReview(TimeStampedModel):
This is where we store the proctored exam review feedback
from the exam reviewers

.. pii: reviews contain video of the exam
retirement to be implemented in https://openedx.atlassian.net/browse/EDUCATOR-4776
.. pii: Reviews contain video of the exam.
Retirement was supposed to be implemented in https://openedx.atlassian.net/browse/EDUCATOR-4776,
but it is not clear that is was. We pessimistically assume that it was NOT retired, but this
assumption should be revisited in https://github.com/openedx/edx-proctoring/issues/1241.
.. pii_types: video
.. pii_retirement: to_be_implemented
.. pii_retirement: retained
"""

# which student attempt is this feedback for?
Expand Down Expand Up @@ -758,10 +760,12 @@ class ProctoredExamSoftwareSecureReviewHistory(TimeStampedModel):
"""
When records get updated, we will archive them here

.. pii: reviews contain video of the exam
retirement to be implemented in https://openedx.atlassian.net/browse/EDUCATOR-4776
.. pii: Reviews contain video of the exam.
Retirement was supposed to be implemented in https://openedx.atlassian.net/browse/EDUCATOR-4776,
but it is not clear that is was. We pessimistically assume that it was NOT retired, but this
assumption should be revisited in https://github.com/openedx/edx-proctoring/issues/1241.
.. pii_types: video
.. pii_retirement: to_be_implemented
.. pii_retirement: retained
"""

# which student attempt is this feedback for?
Expand Down Expand Up @@ -804,10 +808,12 @@ class ProctoredExamSoftwareSecureComment(TimeStampedModel):
This is where we store the proctored exam review comments
from the exam reviewers

.. pii: comment contains free-form text which could be personally-identifying
retirement to be implemented in https://openedx.atlassian.net/browse/EDUCATOR-4776
.. pii: Comment contains free-form text which could be personally-identifying.
Retirement was supposed to be implemented in https://openedx.atlassian.net/browse/EDUCATOR-4776,
but it is not clear that is was. We pessimistically assume that it was NOT retired, but this
assumption should be revisited in https://github.com/openedx/edx-proctoring/issues/1241.
.. pii_types: other
.. pii_retirement: to_be_implemented
.. pii_retirement: retained
"""

# which student attempt is this feedback for?
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@edx/edx-proctoring",
"//": "Note that the version format is slightly different than that of the Python version when using prereleases.",
"version": "4.18.3",
"version": "4.18.4",
"main": "edx_proctoring/static/index.js",
"scripts": {
"test": "gulp test"
Expand Down
Loading