-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't add x-is-pointer-node attribute to Capa problem XML on paste [FC-0062] #35701
fix: Don't add x-is-pointer-node attribute to Capa problem XML on paste [FC-0062] #35701
Conversation
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- ✅ I tested this: on Tutor devstack with and without using the code.
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository.
c5221b5
to
de21b82
Compare
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
When a
problem
component is pasted from a library into a course, we use a hack that adds a "temporary"x-is-pointer-node
attribute to the XML to preventXmlMixin
from looking for more XML data in a place that doesn't exist (the filesystem). However, this somehow causes the temporaryx-is-pointer-node
attribute to end up in the capa problem'sdata
(string) attribute, and authors would see that if they use the advanced editor mode.This PR fixes that by explicitly removing the attribute in cases where it persists.
Supporting information
Relates to openedx/frontend-app-authoring#1377 - this was one of the contributing causes.
Testing instructions
Paste a capa problem component from a library into a course, then open its advanced editor and verify that it doesn't have this attribute in its OLX.
Deadline
Not urgent.
Private ref: FAL-3873