fix: Remove B2C Subscriptions #35303
Conversation
julianajlk
force-pushed
the
julianajlk/REV-3697/subs-cleanup
branch
2 times, most recently
from
803337e to
d6cdbbe
Compare
deborahgu
added
the
waiting for eng review
julianajlk
force-pushed
the
julianajlk/REV-3697/subs-cleanup
branch
3 times, most recently
from
2e4a7b9 to
69d4eea
Compare
|
I plan on taking a first pass at this tomorrow. Sorry for the delay on a review. |
julianajlk
force-pushed
the
julianajlk/REV-3697/subs-cleanup
branch
2 times, most recently
from
c685cf9 to
1b52805
Compare
julianajlk
force-pushed
the
julianajlk/REV-3697/subs-cleanup
branch
3 times, most recently
from
1868257 to
280e1c2
Compare
|
@julianajlk -- I'm wondering if there are some files missing from this PR:
|
lms/static/js/learner_dashboard/views/program_details_sidebar_view.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks for getting this up! Approved with the suggestion that this is a solid candidate for pausing the pipeline. When this goes to Stage, we can assist with the testing process as well
julianajlk
force-pushed
the
julianajlk/REV-3697/subs-cleanup
branch
2 times, most recently
from
556eed2 to
a28f741
Compare
|
Thank you @justinhynes and @MaxFrank13 for the review! I will plan to pause pipelines next week to test Stage, which includes removing the waffle flag from admin after the code is merged (flag is off for everyone at the moment) |
|
Passing by thoughts: Sad to see the subs code going away too (after I had to see subs project go away) 🥲 |
deborahgu
removed
the
waiting for eng review
julianajlk
force-pushed
the
julianajlk/REV-3697/subs-cleanup
branch
from
a28f741 to
6182387
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
REV-3697.
Removing all of the B2C Subscriptions related code we added since subscriptions are no longer active, in an effort to remove any 2U specific code.
This includes the revoke entitlements
/subscriptions/entitlements/revokeendpoint.Accompanying
edx-internalPR - https://github.com/edx/edx-internal/pull/11416TODOs:
Done on the last commit, plus preparatory PR merged for this file with older changes chore: Update LMS openapi spec yml file #35400 to separate concerns.