fix: add missing end field #34880
Merged
fix: add missing end field #34880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bszabo
reviewed
May 30, 2024
| @@ -1040,6 +1041,7 @@ def rerun_course(user, source_course_key, org, number, run, fields, background=T | |||
| add_instructor(destination_course_key, user, user) | |||
|
|
|||
| # Mark the action as initiated | |||
| print(fields) | |||
There was a problem hiding this comment.
This looks like lint that needs to be deleted
bszabo
approved these changes
May 30, 2024
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously course reruns done in Studio would update the start date to the default start date or the start date provided via the api, but did not update the end date. As a result the end date would be copied from the original run of the course. If the course author did not change it before the re-run, it could end up messing up the start/end dates for a course and list a course as archived instead of active. This change updates the end date for a course rerun the same way it is done for the start date. Now when a course is re-ran it will default to no end date (the behavior as a new course) or have the end date provided via the api. This change impacts Course Authors.
Supporting information
JIRA Ticket: TNL-11477
Testing instructions
Deadline
None