-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added tracking events for password reset initiation #34825
Conversation
441264a
to
d2010ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[For my understanding] Why aren't we using segment.track?
And why is this event being introduced?
e4bc3e2
to
b94fb78
Compare
As per my understanding, the segment.track method links each emitted event to a specific user and is preceded by the identify call which requires a user id/authentication. I believe some of the password reset cases are for users that are not logged in so this might not be possible there. For uniformity, the same method is applied on the cases where a user id might be available too. Please let me know if this is not the case and I'll review.
Many learners reported that they did not receive password reset emails last month and there was barely any data available to investigate the issue at the time wrt running bulk analytics. We're aiming to add tracking to be able to deal with such cases in the future, this PR is a starting point for this effort. |
common/djangoapps/student/management/commands/recover_account.py
Outdated
Show resolved
Hide resolved
f20649e
to
9a307c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the PR description? We are not sending the email now
9a307c0
to
17f48ad
Compare
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
INF-1379
Added a new event 'edx.user.passwordreset.initiated' which tracks the user id and the source of trigger for the password reset.