Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added tracking events for password reset initiation #34825

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

sohailfatima
Copy link
Contributor

@sohailfatima sohailfatima commented May 21, 2024

INF-1379

Added a new event 'edx.user.passwordreset.initiated' which tracks the user id and the source of trigger for the password reset.

@sohailfatima sohailfatima requested a review from a team as a code owner May 21, 2024 08:43
@sohailfatima sohailfatima force-pushed the fatima/inf-1379 branch 3 times, most recently from 441264a to d2010ea Compare May 21, 2024 11:03
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[For my understanding] Why aren't we using segment.track?

And why is this event being introduced?

@sohailfatima sohailfatima force-pushed the fatima/inf-1379 branch 2 times, most recently from e4bc3e2 to b94fb78 Compare May 21, 2024 12:16
@sohailfatima
Copy link
Contributor Author

sohailfatima commented May 21, 2024

@syedsajjadkazmii

[For my understanding] Why aren't we using segment.track?

As per my understanding, the segment.track method links each emitted event to a specific user and is preceded by the identify call which requires a user id/authentication. I believe some of the password reset cases are for users that are not logged in so this might not be possible there. For uniformity, the same method is applied on the cases where a user id might be available too. Please let me know if this is not the case and I'll review.

And why is this event being introduced?

Many learners reported that they did not receive password reset emails last month and there was barely any data available to investigate the issue at the time wrt running bulk analytics. We're aiming to add tracking to be able to deal with such cases in the future, this PR is a starting point for this effort.
Additionally, this email might be shifted to Braze in the future, so this will also help us gain an accurate idea of the volume.

Copy link
Contributor

@asadazam93 asadazam93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the PR description? We are not sending the email now

@sohailfatima sohailfatima merged commit 88339bc into master Jun 4, 2024
45 checks passed
@sohailfatima sohailfatima deleted the fatima/inf-1379 branch June 4, 2024 07:38
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants